search

cake-build / cake

:cake: Cake (C# Make) is a cross platform build automation system.
https://cakebuild.net
MIT License
3.85k stars 724 forks source link

GH-4128: Fix Inconsistent determination of positional Argument when using context.Arguments versus context.Argument #4139

Closed EdLichtman closed 1 year ago

EdLichtman commented 1 year ago

…Arguments versus context.Argument

augustoproiete commented 1 year ago

Thanks for the PR @EdLichtman. Could you please reply to this as per the instructions here: https://github.com/cake-build/cake/pull/4139#issuecomment-1496141739 ?

EdLichtman commented 1 year ago

@augustoproiete I can do that, but it's not the complete changelist you have, and like I mentioned in Issue #4128 I haven't yet been able to run the tests. Would it be alright for me to perform the checks and get my change in without it? It looks like I haven't fully implemented the changes you implemented, so it's still an incomplete change.

augustoproiete commented 1 year ago

@EdLichtman That's fine. I can merge your changes and mine on the same PR - or you can bring the missing changes I did to this MR, and we close mine

EdLichtman commented 1 year ago

@microsoft-github-policy-service agree

augustoproiete commented 1 year ago

@EdLichtman your changes have been merged, thanks for your contribution :+1: