search

cake-build / cake

:cake: Cake (C# Make) is a cross platform build automation system.
https://cakebuild.net
MIT License
3.85k stars 724 forks source link

Upgrade Spectre.Console to v0.46.0 #4140

Closed FrankRay78 closed 1 year ago

FrankRay78 commented 1 year ago

This PR upgrades spectre.console from 0.45.0 to 0.46.0 (latest) by upgrading the NuGet package reference, and the subsequent minor build issue introduced (see: https://github.com/cake-build/cake/issues/4138) has been fixed by a trivial code change.

Background: my interest in upgrading to the latest spectre.console is in anticipation of being able to fix this cake issue, https://github.com/cake-build/cake/issues/3279. The necessary change to spectre.console has been made and committed (714cf179cb349597a8b775287ac8299584b18617), although it does not reside in the 0.46.0 release and is scheduled for 0.47.0. Either way, I wanted to upgrade the version of spectre.console used by cake to the latest and address any issues that may arise, to ease the future upgrade to 0.47.0

nb. spectre.console release notes for 0.46.0 are here: https://github.com/spectreconsole/spectre.console/releases/tag/0.46.0

The biggest visible improvement arising from using spectre.console 0.46.0 for cake users is showing the default value of any arguments, see:

image

FrankRay78 commented 1 year ago

Looks like .LeftAligned() in AnsiConsole.Render(new FigletText("Cake").LeftAligned().Color(Color.Red)); in the integration tests is breaking the build. Perhaps a 'not-intended' breaking change in spectre.console. I'll investigate...

patriksvensson commented 1 year ago

@FrankRay78 LeftAligned was renamed to LeftJustified.

augustoproiete commented 1 year ago

@FrankRay78 your changes have been merged, thanks for your contribution :+1: