File type check on macosx (if file is "dylib")

cake-build / cake

:cake: Cake (C# Make) is a cross platform build automation system.

https://cakebuild.net

MIT License

3.89k stars 724 forks source link

File type check on macosx (if file is "dylib") #4206

Closed moljac closed 1 year ago

moljac commented 1 year ago

Context: https://github.com/cake-build/cake/issues/3996

Added filetype/extension check.

Error experienced:

Error: Bad IL format. 
The format of the file 
    '/Users/runner/work/1/s/tools/Addins/runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.Apple.4.3.0/runtimes/osx.10.10-x64/native/System.Security.Cryptography.Native.Apple.dylib' 
is invalid. 
An error occurred when executing task Error: .NET CLI: Process returned an error (exit code 1)

The error was experienced at intermittent intervals in CI (and local, but not so often) builds for 2 repos:

https://github.com/xamarin/AndroidX https://github.com/xamarin/GooglePlayServicesComponents

In last few weeks, alsmost all builds fail regularly.

https://github.com/xamarin/GooglePlayServicesComponents/pull/801

moljac commented 1 year ago

@devlead @patriksvensson @gep13

Would you be so kind and review this PR, please? We have blocking issue on GPS-FB-MLKit (GooglePlayServicesComponents) both local and CI builds

https://github.com/xamarin/GooglePlayServicesComponents

moljac commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago

Commenter does not have sufficient privileges for PR 4206 in repo cake-build/cake

moljac commented 1 year ago

I cannot squash. Probably because I updated branch with merge commit (I was in a hurry and doing few things in parallel) and forgot to squash before update.

devlead commented 1 year ago

@moljac your changes have been merged, thanks for your contribution 👍

devlead commented 1 year ago

@moljac FYI a pre-release package is now available on our Azure Artifacts feed: https://dev.azure.com/cake-build/Cake/_artifacts/feed/cake/NuGet/Cake.Tool/overview/3.2.0-alpha0025

moljac commented 1 year ago

@moljac FYI a pre-release package is now available on our Azure Artifacts feed: https://dev.azure.com/cake-build/Cake/_artifacts/feed/cake/NuGet/Cake.Tool/overview/3.2.0-alpha0025

Great! It works locally. 2 GPS-FB-MLKit PRs build nicely.

When is 3.2.0 supposed to be released?

Thanks a lot!

moljac commented 11 months ago

Some feedback: 3.2.0 preview fixes the issue. Confimed on 2 local MBPs and on CI (GPS-FB-MLKit repo https://github.com/xamarin/GooglePlayServicesComponents)

thanks