search

cake-build / resources

Contains different kind of resources such as bootstrappers and configuration files.
MIT License
54 stars 78 forks source link

Use SystemProxy in WebClient #35

Closed aateeque closed 7 years ago

aateeque commented 7 years ago

This enables executing the powershell script behind corporate proxy for example

dnfclas commented 7 years ago

@aateeque, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request. Thanks, .NET Foundation Pull Request Bot

aateeque commented 7 years ago

This was initially opened in the cake-build/cake#1765

gep13 commented 7 years ago

@aateeque would an equivalent change also be required in the build.sh file?

aateeque commented 7 years ago

Don't think so; typically on Linux proxy would be handled by cntlm & http_proxy/https_proxy variables

gep13 commented 7 years ago

@devlead can I get your thoughts on this?

gep13 commented 7 years ago

@aateeque your changes have been merged, thanks for your contribution 👍