GH59: Added correct TLS version

[gep13]

Fixes #59

[gep13]

@devlead hmm, looks like PowerShell Version 2 doesn't like this 😢

[gep13]

@mholo65 I think I am right in saying that this will be needed for any request against GitHub, i.e. the packages.config, cake.config, etc.

[bjorkstromm]

Ah, yes! How come we haven’t seen this issue before, until recently with downloading dotnet-install.ps1? GH enforced TLS1.2 back in February 2018..?!

[devlead]

@devlead hmm, looks like PowerShell Version 2 doesn't like this 😢

Ah it's running .NET 2.x I guess... perhaps time to drop 2 support or check if type exist/is null/ps version.

[devlead]

@mholo65 could be because the redirect via cloudflare.

[gep13]

@mholo65 I "think" we get away with it, due to our higher .Net Framework requirement, but I don't think there is any problem with being explicit.

@devlead said... Ah it's running .NET 2.x I guess... perhaps time to drop 2 support or check if type exist/is null/ps version.

I changed the logic slightly to do similar to how Chocolatey does it, and the build works again :-D

[bjorkstromm]

could be because the redirect via cloudflare.

Makes sense!

[devlead]

Merged via ebab27f6a26bbbeba5d0367a79f8aa66a23cc4b5