search

cake-build / resources

Contains different kind of resources such as bootstrappers and configuration files.
MIT License
54 stars 79 forks source link

Quotes surrounding 'script' and 'target' #79

Closed Roadrunner67 closed 4 years ago

Roadrunner67 commented 4 years ago

Looks good to me 👍 Could you however squash the commits to a single one?

Sorry, I wasn't focused on that - it should be one commit now.

Roadrunner67 commented 4 years ago

@patriksvensson I am sorry to bother you again, but I have just discovered a scenario, where it does not work. Starting with $cakeArguments = "" makes cakeArguments become a string, whereas $cakeArguments = @() makes it an array. The succesive $cakeArguments -join " " has no effect on a string.

I can make a new PR adressing this. PR #80 it is.