search

cake-contrib / Cake.AddinDiscoverer

Tool to aid with discovering information about Cake Addins
MIT License
5 stars 6 forks source link

Don't create pull request for lower version numbers #223

Closed pascalberger closed 1 year ago

pascalberger commented 1 year ago

If for example version 2.0 is available of an addin, and later a hotfix 1.0.1 is released, addin discoverer should not create a PR as long as the newly published version is lower than the previous version.

See https://github.com/cake-build/website/pull/2639 for an example

Jericho commented 1 year ago

The current logic sorts addin releases chronologically. Therefore the most recent release is simply the one that was published most recently, regardless of version number. This explains why AddinDisco creates a PR for a hotfix despite the fact that there is a release with a higher version number.

I'm improving this logic and take the version number into consideration when sorting addin releases which will resolve the problem.

Jericho commented 1 year ago

Fixed in 5.3.0 which was released today