cake-contrib / Cake.AddinDiscoverer

Tool to aid with discovering information about Cake Addins
MIT License
5 stars 6 forks source link

UpdateCakeRecipe not correctly determining that an addin has skipped a version of Cake #230

Closed Jericho closed 8 months ago

Jericho commented 8 months ago

Currently, the UpdateCakeRecipe step is able to distinguish the version of a given addin compatible with:

This logic completely ignores any release of a given addin compatible with a version of Cake which is between the 'next version (2.0 in the example above) and the most recent version of Cake. This flawed logic was not a problem until recently because 3.0 was the latest version of Cake and there were no major version of Cake between 2.0 and 3.0. This changed over the last weekend because Cake 4 was released and now 4.0 is the latest and 3.0 falls between the "next" version and the latest.

Cake,Coverlet is an example of such an addin: they have a version for Cake 1, they skipped Cake 2, released a version for Cake 3 and haven't released a version for Cake 4. I'm sure there are other examples, but this is the one I noticed earlier today.

The consequence of the flaw in our logic is that AddinDisco is indefinitely waiting for a version compatible with Cake 2 to be released as can be observed in this issue image

The expected behavior is for the Addindisco to give up waiting for a version compatible with Cake 2.0 and add the following sentence in the issue I referenced above:

Cake.Coverlet skipped support for Cake 2.0.0. Therefore this reference will not be upgraded.

Jericho commented 8 months ago

@gep13 just want to make sure you are aware

Jericho commented 8 months ago

This is very similar to the issue that I fixed several months ago in commit 06f99c7da0e26bbe67ffe5f37b32753d79f31cc0

Jericho commented 8 months ago

AddinDiscoverer 5.10 published and problem is resolved: image