search

cake-contrib / Cake.HockeyApp

This Addin for the Cake allows you to upload your package to HockeyApp.
http://cakebuild.net/dsl/hockeyapp
MIT License
4 stars 13 forks source link

Changed base URL for faster uploads #31

Closed msjogren closed 7 years ago

msjogren commented 7 years ago

Using upload.hockeyapp.net instead of rink.hockeyapp.net when uploading binaries can give significantly faster upload times. The former is based on Amazon CloudFront CDN. It is a supported alternative for create/update REST endpoints according to https://support.hockeyapp.net/discussions/problems/33355-is-uploadhockeyappnet-available-for-general-use

For example, uploading a 75 MB UWP .zip package from where I'm located is at least 5x faster (seconds instead of minutes) after this change.

It works for all requests right now since all the addin does is uploads. If #2 is ever to be implemented, then one would have to pick the right base URL (rink. for queries) depending on usage.

gep13 commented 7 years ago

@ghuntley @redth @reicheltp can any of you offer any input on this PR? I will be honest and say that I don't know enough about it. Thanks.

RLittlesII commented 7 years ago

@gep13 My two cents, default to https://rink.hockeyapp.net, and allow the settings to accept an alternate url.

Redth commented 7 years ago

I think @RLittlesII advice is sound here.

RLittlesII commented 7 years ago

@gep13 if @msjogren isn't in a position to make this change, I am looking into a few other issues in this addin and can add it to my list.

gep13 commented 7 years ago

@RLittlesII if you could, that would be great! :+1:

I think your suggestion regarding allowing overriding of the URL makes a lot of sense.

RLittlesII commented 7 years ago

@msjogren This has been address with #32

msjogren commented 7 years ago

@RLittlesII great, thanks!