search

cake-contrib / Cake.Incubator

This project contains various experimental but useful extension methods and aliases for Cake
http://cakebuild.net/api/Cake.Incubator/
Other
19 stars 26 forks source link

Bump Cake to 2.0.0 #172

Closed gitfool closed 2 years ago

gitfool commented 2 years ago

Fixes #170.

gitfool commented 2 years ago

GitVersion is failing with:

System.DllNotFoundException: Unable to load shared library 'git2-106a5f2' or one of its dependencies.

But this should work since I know 5.8.1 works with ubuntu-latest as I use that combo myself. 😖

What I don't understand is where the reference to 'git2-106a5f2' is coming from, which is used by an older version (5.3.1).

gitfool commented 2 years ago

@gep13 what am I missing? 🤔

nils-a commented 2 years ago

@gitfool When I build, there's Cake.Git in version 0.22.0 in the addins folder. This uses LibGit2Sharp-0.26.2 which uses LibGit2Sharp.NativeBinaries-2.0.306 which provides exactly git2-106a5f2.

IMHO the first version of Cake.Git to support ubuntu 20.04 is 1.1.0 - which targets Cake 1.0.0 and is currently not supported by Cake.Recipe.

gitfool commented 2 years ago

@nils-a thanks for the tip! Looks like the Cake.Git dependency is coming from Cake.Issues.Recipe and that this could be fixed by bumping Cake.Issues.Recipe from 0.4.3 to 1.3.2:

Not sure but such a bump would probably have to be released in a patched Cake.Recipe version 2.2.2 for it to be useable while still building against Cake 1.0.0.

Update: I couldn't get this to work locally due to mixing Cake 0.38.5 and Cake 1.0.0.

gitfool commented 2 years ago

@gep13 @nils-a ready for review after I reverted the github workflow platforms to avoid issues with git native dependencies. 😁