search

cake-contrib / Cake.Recipe

:page_with_curl: A set of convention based Cake scripts
https://cake-contrib.github.io/Cake.Recipe
MIT License
70 stars 53 forks source link

Upgrading libs in Cake.Recipes #865

Closed AdaskoTheBeAsT closed 2 years ago

AdaskoTheBeAsT commented 3 years ago

Hi,

in repo Cake.Issues.Reporting.SonarQube I encountered a problme with building script which uses Cake.Recipe. As I tried to narrow problems I started first with upgrading libs to some newer versions - in pull request I will provide proposed small changes - please advise

gep13 commented 3 years ago

What issues did you encounter? Do you have a link to the problem that you were/are seeing?

AdaskoTheBeAsT commented 3 years ago

Hi - build pipeline just throwed an error on my PR https://github.com/cake-contrib/Cake.Issues.Reporting.SonarQube/pull/6 https://dev.azure.com/cake-contrib/Cake.Issues.Reporting.SonarQube/_build/results?buildId=6884&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=c37637b8-ed57-5a02-c556-da2855a7e2d3

but preparing PR for that also revealed one more issue in Cake.Issues.Recipe https://github.com/cake-contrib/Cake.Issues.Recipe/issues/247 - for which I also prepared PR - https://github.com/cake-contrib/Cake.Issues.Recipe/pull/248

AdaskoTheBeAsT commented 3 years ago

but my PR for Cake.Issues.Recipe is blocked - at first at ubuntu 16.04 - i upgraded ubuntu to 20.04 now it is this image it seems some problem with Microsoft.CodeAnalysis.FxCopAnalyzers - btw it was replaced by Microsoft.CodeAnalysis.NetAnalyzers
image

Please help

gep13 commented 3 years ago

As per the documentation, Cake.Recipe (in the current released version) supports building only with 0.38.5 of Cake: https://cake-contrib.github.io/Cake.Recipe/docs/overview/requirements/windows

Now, that is not to say that the application/project that you are building (in this case Cake.Issue.Reporting.SonarCube) can't target Cake 1.x.x, it just means that the version of Cake that is used to build that project, needs to be 0.38.5. There is more work that would need to be done here in Cake.Recipe to allow usage of Cake 1.x.x. Simply updating the references addins/tools/modules etc, won't be enough.

AdaskoTheBeAsT commented 3 years ago

Ahh ok i see - you're right