cake-contrib / Cake.Recipe

:page_with_curl: A set of convention based Cake scripts
https://cake-contrib.github.io/Cake.Recipe
MIT License
70 stars 53 forks source link

`No such host is known` during teardown #995

Closed Jericho closed 2 months ago

Jericho commented 7 months ago

The symptom that caused this issue to be raised was the following error:

No such host is known

during the execution of the teardown action.

My build script just failed during teardown due to the following exception: The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: System.AggregateException: One or more errors occurred. (No such host is known. (api.gitter.im:443)) (build log here).

I'm guessing this is a consequence of Gitter being acquired by Element back in 2020 and the fact that, earlier this year, they completed the move of their chat platform to Element's "Matrix" platform (announcement here).

I will change the shouldPostToGitter to false in my recipe.cake but this parameter should probably default to false in Cake.Recipe from now on.

nils-a commented 7 months ago

Agreed.

Since Cake.Gitter does no longer work, we probably should remove it. Or maybe replace it with something different? (Matrix, GitHub discussion, discord...)

Jericho commented 7 months ago

I submitted two PRs:

The first one is non-breaking and can be easily merged. The second one is a breaking change, as several parameters are removed. Therefore it should probably be postponed until the next major release of Cake.Recipe

gep13 commented 2 months ago

@nils-a said... Since Cake.Gitter does no longer work, we probably should remove it.

Yes, I think that this is the correct course of action.

@nils-a said... Or maybe replace it with something different? (Matrix, GitHub discussion, discord...)

If someone wants to pick this up, I would happily review and merge.

For now, let's move ahead with the removal of posting to Gitter, and get it released in the next version of Cake.Recipe.