search

cake-contrib / Cake.ResxConverter

Cake addin for ResxConverter
https://cakebuild.net/extensions/cake-resxconverter/
MIT License
0 stars 5 forks source link

nuspec is using direct .dll reference instead of package. #1

Closed jzeferino closed 7 years ago

jzeferino commented 7 years ago

The Cake.ResxConverter .nuspec has references to the .dll dependencies. Could make sense to reference nuget packages instead.

luisgoncalves commented 7 years ago

I think Cake addins must include all the needed assemblies in the package. Cake won't go through the package dependencies to add other assemblies.

jzeferino commented 7 years ago

But its a Cake thing? Guess I've seen .net library​s referencing other dependcies via package reference.

luisgoncalves commented 7 years ago

Yeah, a detail on Cake usage of packages. But I'm not 100% sure. Need to check.

On Apr 16, 2017 12:52, "jzeferino" notifications@github.com wrote:

But its a Cake thing? Guess I've seen .net library​s referencing other dependcies via package reference.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jzeferino/Cake.ResxConverter/issues/1#issuecomment-294347770, or mute the thread https://github.com/notifications/unsubscribe-auth/ADyghV_O5QIrhR0SSX0WWCCysd76AkEfks5rwgELgaJpZM4M-fOv .

luisgoncalves commented 7 years ago

I've double checked this with the Cake team. All the dependencies should be contained in the addin package.