search

cake-contrib / Cake.Sonar

:cake: :jigsaw: Cake addin to execute the MSBuild scanner for SonarQube in Cake builds
https://cakebuild.net/extensions/cake-sonar/
MIT License
31 stars 24 forks source link

Support Cake 2.0.0 #109

Closed twenzel closed 2 years ago

twenzel commented 2 years ago

Fixes #108 Fixes #107 Fixes #106

augustoproiete commented 2 years ago

Thanks @twenzel LGTM. Will leave it for @tomstaijen to review and next steps

HofmeisterAn commented 2 years ago

We need an updated package too. It looks like a few people need it as well, but changes are not accepted. I do not know if it is the right approach, but if you create a pull request on my fork, I can take care about the pipeline and release. We only need a different name...

mcliment commented 2 years ago

I was wondering that too but I think I'd be better to take ownership of this repo instead of doing forks. I'll try to contact the administrators of cake-contrib to see if I can do that.

tomstaijen commented 2 years ago

I'm happy to transfer my role ownership to a new maintainer person/team. I don't have bandwidth to support this as I currently not use .NET nor sonar.

twenzel commented 2 years ago

@tomstaijen great to hear. Who is the new maintainer person/team? We need to fix the CI build.

tomstaijen commented 2 years ago

One problem down. Next problem is Ubuntu does not know GitVersion.exe..

twenzel commented 2 years ago

Either we switch back to Visual Studio 2022 image or find a solution for GitVersion... @tomstaijen Found a solution. See #110

HofmeisterAn commented 2 years ago

I'm happy to transfer my role ownership to a new maintainer person/team. I don't have bandwidth to support this as I currently not use .NET nor sonar.

@tomstaijen as @twenzel already asked, who is the new maintainer person / team? It would be nice if we can keep the package up to date. I'm happy to help and join the team, if there is already one.

tomstaijen commented 2 years ago

Mark Climent has been added as maintainer. I'll tell them to add you too!

https://github.com/cake-build/cake/discussions/3738