cake-contrib / Cake.Sonar

:cake: :jigsaw: Cake addin to execute the MSBuild scanner for SonarQube in Cake builds
https://cakebuild.net/extensions/cake-sonar/
MIT License
31 stars 24 forks source link

Various paths are just strings and not "made absolut" #31

Closed Roemer closed 7 years ago

Roemer commented 7 years ago

Many settings (e.g. NUnitReportsPath, DotCoverReportsPath, VsCoverageReportsPath) are just strings and therefore are not made absolute (and quoted after PR #30). I think they all should be of type FilePath so that they behave correctly.

tomstaijen commented 7 years ago

making paths absolute should not be required. the scanner supports relative paths just fine. going to reverse this change in favor of #35