cake-contrib / Cake.Vagrant

Cake addin to control Vagrant through the CLI
https://cakebuild.net/extensions/cake-vagrant/
MIT License
0 stars 6 forks source link

Update nuspec with Cake Contrib Icon #4

Closed gep13 closed 7 years ago

agc93 commented 7 years ago

What do you think of this as a middle ground @gep13 ?

screenshot 75

(obviously replace transparency with white)

gep13 commented 7 years ago

@agc93 have you obtained permission from Hashicorp to use the Vagrant icon? How is it licensed?

agc93 commented 7 years ago

Vagrant itself is MIT, and their website indicates no copyright for the logo or even the name, and the logo is listed on Wikipedia as CC-BY-SA. Is it worth maybe adding a disclaimer to the README just in case?

gep13 commented 7 years ago

Yes, I think that would be best.

Do you think it might be worth inverting the image, so that it is more like: https://www.nuget.org/packages/Cake.Xamarin/

i.e. where Cake is the main portion of the icon?

agc93 commented 7 years ago

Yeah I might switch that around and give it a look, then I'll add a basic "all rights reserved" disclaimer about the logo on the README.

gep13 commented 7 years ago

Sounds good to me. :+1:

agc93 commented 7 years ago

screenshot 78

Doesn't work quite as well but is probably a bit clearer

gep13 commented 7 years ago

@agc93 LGTM! 👍

gep13 commented 7 years ago

Thanks again for creating this Cake Addin, we really appreciate the effort that you have put in to creating it.

We, the Cake Team, recently announced a new Cake Contrib Icon, details of which can be found here:

http://cakebuild.net/blog/2017/06/new-cake-contrib-icon

Would you consider changing the nuspec file for your NuGet Package to use this new Cake Contrib Icon? If so, the recommended URL to use is:

https://cdn.rawgit.com/cake-contrib/graphics/a5cf0f881c390650144b2243ae551d5b9f836196/png/cake-contrib-medium.png

Details of the above URL can be found in the repository here:

https://github.com/cake-contrib/graphics

Please let me know if you have any questions.

agc93 commented 7 years ago

@gep13 Icon updated as discussed:

https://www.nuget.org/packages/Cake.Vagrant/0.4.0-unstable0006

Will go stable with next release :smile:

gep13 commented 7 years ago

:+1: