Closed squid-box closed 1 year ago
Merging #218 (5d3c0c0) into develop (10515df) will increase coverage by
0.03%
. The diff coverage is92.30%
.
@@ Coverage Diff @@
## develop #218 +/- ##
===========================================
+ Coverage 94.27% 94.30% +0.03%
===========================================
Files 14 14
Lines 629 650 +21
Branches 92 94 +2
===========================================
+ Hits 593 613 +20
Misses 16 16
- Partials 20 21 +1
Impacted Files | Coverage Ξ | |
---|---|---|
src/Tasks/TargetFrameworkVersions.cs | 91.08% <92.30%> (+0.48%) |
:arrow_up: |
:mega: Weβre building smart automated test selection to slash your CI/CD build times. Learn more
Thanks for working on this. π
Looks good at first glance, I'll have a closer look when I can get to a computer.
@squid-box would you also be in a position to update the docs?
(Seems I missed those for the 2.0.0 version, too. π)
@nils-a: I'm really moving into dangerous territory here, documenting something I'm very vaguely understanding π - but I've made an attempt.
I'm not sure if there also needs to be an update to the module version checks for 3.0.0, they're untouched so far (but I did update their documentation as well, for better or worse).
I'm really moving into dangerous territory here, documenting something I'm very vaguely understanding
I'll guide you, I promise π
I'm not sure if there also needs to be an update to the module version checks...
Yes, I'll add some comments to changes you made to the docs. The implementation should reflect that accordingly.
I'll have access to a decent computer (rather: keyboard and monitor) on Monday if you need more help than I can provide via mobile.
@squid-box Perfect. Thanks for getting this done.
I have fixed up the commits a bit (hope you don't mind) and added one additional change (CCG0009 - Suggested Cake version to use)
@squid-box your changes have been merged, thanks for your contribution :+1:
@all-contributors please add @squid-box for code.
@nils-a
I've put up a pull request to add @squid-box! :tada:
As noted in #217, the supported frameworks needs to be updated following the release of Cake 3.0.0.
As best as I can tell, this is what was necessary to change - and local tests at least work with the version produced with my changes. I'm very much open to feedback on this, should I have missed/misunderstood something.