search

cake-contrib / Cake_Git

Cake AddIn that extends Cake with Git features using LibGit2 and LibGit2Sharp
https://cakebuild.net/extensions/cake-git
Other
39 stars 64 forks source link

Add GitCloneSettings support #17

Closed wekempf closed 8 years ago

wekempf commented 8 years ago

Pardon the noob here. This is my very first pull request. So if I've done anything wrong, just let me know.

I'm new to Cake, but I have need for some build automation scripts that will use Git to do more than the current Cake.Git supports. Hence, this (and future) pull request(s). I've started with a simple one. I need to be able to clone a repo, checking out a specific branch. This is fairly easy to support by following the typical Cake convention of having an overload that takes a Settings object. I've done this for the two existing GitClone methods, and the GitCloneSettings I added supports all of the same features that CloneOptions in LibGit2Sharp gives. I've tried to follow existing practice, though without a contributions document I may have messed something up style wise. I've also attempted to add an integration test for this, though Cake testing is a new concept to me, and I may well have done something there you don't care for.

All in all, though, this is a fairly simple addition, so it should be an easy review.

devlead commented 8 years ago

LGTM 👍 Merged, thanks for your contribution!