search

cake-contrib / Cake_Git

Cake AddIn that extends Cake with Git features using LibGit2 and LibGit2Sharp
https://cakebuild.net/extensions/cake-git
Other
39 stars 63 forks source link

Version of LibGit2Sharp is incompatible with Cake.GitVersioning addin #90

Open flcdrg opened 5 years ago

flcdrg commented 5 years ago

As documented in https://github.com/AArnott/Nerdbank.GitVersioning/issues/288, Cake.Git and Cake.GitVersioning both reference LibGit2Sharp, but if they happen to reference different versions, Cake is unable to compile the build script.

It would be good to upgrade Cake.Git to be on par with Cake.GitVersioning so both latest versions of the addins can be used together.

pascalberger commented 5 years ago

With #108 Cake.Git was updated to LibGit2Sharp 0.26.0 (latest stable release). But I saw that Cake.GitVersioning in the meantime is using LibGit2Sharp 0.27.0-preview-0007, so there might still be issues with using them together.

flcdrg commented 5 years ago

I wonder if something like ilmerge could be used to inline the LibGit2Sharp assembly for both projects? There's still the matter of LibGit2Sharp.NativeBinaries though, so maybe not. It's a pity Cake addins aren't isolated a bit more from each other.

devlead commented 5 years ago

At the moment they can't be more isolated from each other, .NET Core 3 will likely introduce a component model that'll enable better isolation.