search

cake-contrib / Cake_Git

Cake AddIn that extends Cake with Git features using LibGit2 and LibGit2Sharp
https://cakebuild.net/extensions/cake-git
Other
39 stars 63 forks source link

Update to LibGit2Sharp 0.26.0 #95

Closed pascalberger closed 5 years ago

pascalberger commented 5 years ago

Update to LibGit2Sharp 0.26.0. This fixes an issue I experienced with LibGit2Sharp 0.25.2 which reported wrong file status for files added to the workspace which are ignored.

devlead commented 5 years ago

There seems to be an "unrelated" issue with, the build script needs to be refactored to now that libgitsharp has multiple framework monikers.

pascalberger commented 5 years ago

@devlead The issue seems not to be with the tests but with the generated NuGet package which contains the \lib\netstandard2.0\libgit2-572e4d8.so file multiple times.

pascalberger commented 5 years ago

Seems like here the paths get lost and the files from the different architectures are ending in the package.

What's the idea here which architecture should be choosen?

devlead commented 5 years ago

Good question, issue is that libgitsharp has changed it's structure, Cake.Git nuget package need to change so it conforms to the new layout when it includes managed and native binares, so libgit sharp can resolve things correctly.

I haven't had the cycles to investigate this at all yet, could be a quick fix, could be a little more work.

pascalberger commented 5 years ago

Closed in favor of #108