cake-contrib / Home

:house: This is the hub for all the projects that are part of the Cake Contrib Organization.
https://cakebuild.net/community/cake-contrib
MIT License
13 stars 8 forks source link

Outdated statistics in Status.md #41

Closed Jericho closed 6 years ago

Jericho commented 6 years ago

There are some statistics at the top of Status.md which may or may not be up-to-date and may not be in line with the statistics automatically calculated by the "Audit" process. For instance, Stus.md says there are 217 addins but the audit process has discovered 219 addins.

I suggest we remove the stats from Status.md and replace it with a link to the audit report.

gep13 commented 6 years ago

I have no objections to this, in fact, I will go and do that just now.

gep13 commented 6 years ago

@Jericho why is there such a big difference between the audited number of addins in the cake-contrib organisation? 110 to 68?

gep13 commented 6 years ago

@Jericho I know we can't get it yet, but the one piece of missing information in the audit summary would be the cake-contrib user on NuGet.org

gep13 commented 6 years ago

Done.

Jericho commented 6 years ago

Regarding package owner: I have a issue on hold to remind me to add this information when the necessary improvement is made to the nuget API.

Regarding number of transferred addins : I use the following logic to determine if add-in has been transferred. Does that match your logic?

gep13 commented 6 years ago

So, I think it should match, yes.

Basically, I was getting the number that I had from the number of repositories in the Organisation here:

https://github.com/cake-contrib

Which is currently at 118. Could it be that some of the links in the status page need to be updated, or perhaps (better) the links in the yml files need to be updated?

Jericho commented 6 years ago

Yes indeed: if the project link does not look like http://github.com/cake-contrib/<project-name> it will not be considered to be under the cake-contrib organization.

gep13 commented 6 years ago

@Jericho okay, so I think we need to take a task to ensure that all those links are correct. Could you raise an issue on the Cake website repo, and here?

Jericho commented 6 years ago

To confirm your suspicion, I looked at one example of an addin that was in Addin.md but is marked as "not being transferred to cake-contrib" by the audit tool. Sure enough, the Repository property in the yaml file is a link to the repo under the original author

Jericho commented 6 years ago

Done: https://github.com/cake-build/website/issues/515

Jericho commented 6 years ago

The number of addins that were listed in addin.md: 118 The number of addins marked as "transfered to cake-contrib" by the audit tool: 68 Difference between these two numbers: 50

This leads me to conclude there are roughly 50 yml files with an incorrect Repository property.

gep13 commented 6 years ago

Okay, so I think I see why there is such a big difference.

There are a number of addin's that don't yet have yaml files created...

Cake.PinNuGetDependency Cake.WindowsAppStore Cake.Markdownlint Cake.Graph Cake,Eazfuscator.Net Cake.Grunt Cake.Email.Common Cake.Bower Cake.Karma Cake.Issues.Reporting Cake.Issues.Reporting.Generic Cake.Mage Cake.Netlify Cake.Markdown-Pdf Cake.ServiceFabric Cake.ScheduledTasks Cake.EventLog Cake.SignClient Cake.OpenVsixSignTool

Then, there are some addin's in the cake-contrib organisation that are no longer being used:

Cake.Prca.Issues.Markdownlint Cake.Prca.Issues.EsLint Cake.Prca.PullRequests.Tfs Cake.Prca.Issues.DocFx Cake.Prca.Issues.InspectCode Cake.Prcs.Issues.MsBuild Cake.Prca Cake.Prca.Website Cake.Prca.Issues.Stylelint Cake.Prca.Issues.TSLint

And then of course, there are modules:

Cake.Chocolatey.Module Cake.DotEnv.Module Cake.DNF.Module Cake.LongPath.Module Cake.Npm.Module

I have updated the yaml files that currently do exist in the website to point to the correct location.

Jericho commented 6 years ago

Excellent. The audit tool will run on schedule in an hour or so. Your improvements will most certainly make a big difference.

gep13 commented 6 years ago

Yip, that new number looks a lot better, and I think the remaining can be explained, and we can correct it.