cake-tech / cake_wallet

The open source repository for Cake Wallet, a noncustodial multi-currency wallet, and Monero.com, a noncustodial Monero-only wallet. Need help? Check out https://guides.cakewallet.com
https://cakewallet.com
MIT License
576 stars 161 forks source link

CakeWallet to Monero Node RPC-SSL | SSL Option "SSL use" has no function #1496

Open jogii2p opened 2 weeks ago

jogii2p commented 2 weeks ago

I have set my "Monero Node" to "RPC-SSL enabled".

To try the connection over SSL with CakeWallet I thought, I have to switch the button "SSL-use" on. But that was not necessary. I can connect to a SSL-enabled Monero node without, SSL-use on.

edit: I seems that the SSL-use in CakeWallet is always on "auto". (1)--daemon-ssl <arg=autodetect) Enable SSL on daemon RPC connections: enabled|disabled|autodetect

At first glance, this may seem user-friendly, but you can never be sure if you have an SSL connection. This is sometimes very important.

But what is needed is a function for the exclusive use of SSL connections to the RPC node. The use of a password with user is known to me, but not comparable with a SSL connection.

To repeat the function/bug you only need to select a node which is running with the option "rpc-ssl enabled" to connect to it. Then you can try the function of "SSL-use".

The "rpc-ssl enabled" function only works for SSL connections, other connections without SSL are rejected. https://github.com/monero-project/monero/issues/9365

Tried with: Cake_Wallet_v4.18.2_Linux.flatpak Android CakeWallet V 4.18.2

Source: (1) https://getmonero.dev/interacting/monero-wallet-rpc.html

tuxpizza commented 1 week ago

I'm having trouble understanding the issue here.

From my end and testing, if "Use SSL" is on, it only works with SSL-enabled nodes. If its off, it only works with ones that don't support SSL.

jogii2p commented 1 week ago

The "Use SSL" function does not work. Here is meant the "Button" in the gui. I can connect to an SSL-protected node without switching on SSL.

From my end and testing, if "Use SSL" is on, it only works with SSL-enabled nodes. If its off, it only works with ones that don't support SSL.

I cannot confirm this. Which version are you using?

Tried with: Cake_Wallet_v4.18.2_Linux.flatpak Android CakeWallet V 4.18.2

tuxpizza commented 5 days ago

Ok I see what you are getting at.... I think with certain nodes it works because they are using the traditional way of providing SSL (terminating SSL with certs from the node itself) vs with my own node I'm just routing the traffic through a reverse proxy and forcing https, so mine won't work without SSL regardless since my reverse proxy forces it. I tested a node that is using SSL the "proper" way and its true that it works with SSL toggled on and off.

I'll have this looked into