search

cake-tech / cake_wallet

The open source repository for Cake Wallet, a noncustodial multi-currency wallet, and Monero.com, a noncustodial Monero-only wallet. Need help? Check out https://guides.cakewallet.com
https://cakewallet.com
MIT License
642 stars 174 forks source link

Scrambled pin #1500

Open serrq opened 3 months ago

serrq commented 3 months ago

Possibility to randomize the pin digits as a security action, optionally.

Add an on/off 'random' button directly in the numpad to easily activate/deactivate this feature without going in some hidden menu to find it.

Looking the result in Unstoppable Wallet to have an idea.

shortwavesurfer2009 commented 1 month ago

As long as this is optional because scramble is an accessibility nightmare

serrq commented 1 month ago

In the numpad reference design there is a dedicated, on place, button to able/disable the randomizer. So the power is in your hands.

Don't want the scrambled pin? Just push the yellow button and the numpad becomes regular. It has a memory function, so the next time you launches the app, it remembers your last choice made.

1000115983

rottenwheel commented 6 days ago

I think having the randomize button in the PIN pad itself is counterintuitive and a bad UI/UX decision. Not sure why OP refers to a "hidden setting somewhere". I'd very much rather it be a setting found in "Privacy & Security" section of Cake than having a button right in the pad.

User can mistakenly press it while putting in unlock code. It's just... I don't get the UI reason to have it at all.

A classic cake slider to enable/disable and a 'Scramble PIN pad' or something like that, option in privacy and security section, call it a day. My two cents.

serrq commented 6 days ago

Yellow ---> Enabled Grey ---> Disabled

It has "memory" function too. It remember the last user choice made.

The user mustn't pushing the button everytime if its choice is a daily habit.

rottenwheel commented 6 days ago

Doesn't change anything. Put it in settings, not right there in the pad...

mpeter50 commented 3 days ago

I think having a switch for this on the pin pad would make sense because it is not always useful to scramble the numbers. This is a security feature against shoulder surfers and surveillance, right? At home and some other places, when you know no one can be possibly watching, you may want to just use a normal pin pad, and not suffer with a scrambled one.

rottenwheel commented 3 days ago

I think having a switch for this on the pin pad would make sense because it is not always useful to scramble the numbers. This is a security feature against shoulder surfers and surveillance, right? At home and some other places, when you know no one can be possibly watching, you may want to just use a normal pin pad, and not suffer with a scrambled one.

You'd go to settings and enable/disable as you need. 😁

We'll see what Cake team decides. It is a very good feature regardless of how it gets implemented.

mpeter50 commented 3 days ago

You'd go to settings and enable/disable as you need. 😁

Thats true, but I think this may discourage users from using it. Or at least it would make me turn it off the first time I would need to unlock it 3 times on the same day when sitting at home, and then I forget about the feature and it will stay turned off. So for very determined users it would still be useful, but I'm not sure if so for lazy users.

serrq commented 3 days ago

A comfort feature turned in a issue. I have not words.

At a certain point the authority is a good thing.

Before iPad no one felt the need of 10" tablet. After Jobs presented it to the world all ran to checkout to own one.

But before its official presentation Jobs acted like a dictator. He said to the world: "the tablet is so, because I say as it has to be".

This is a similar case.