search

cakebake / markdown-themeable-pdf

ARCHIVED. NOT MAINTAINED. Themeable Markdown Converter (Print to PDF, HTML, JPEG or PNG)
https://atom.io/packages/markdown-themeable-pdf
133 stars 37 forks source link

1 bug and 1 suggestion #1

Closed Gaoura closed 9 years ago

Gaoura commented 9 years ago

Hi !

First of all, thank you for this cool package, it works well on the majority of my markdown files ^^

But I got a problem with one of them : it's so huge that I use some huge comments to navigate in it via the minimap. Only this kind of comments are just stopping the PDF conversion (short comments doesn't stop the conversion : <!-- TOC depth:6 withLinks:1 updateOnSave:1 orderedList:1 --> ) And here is an example of a file which won't be completed as PDF because of the "PREZ" comment : http://pastebin.com/kVpRWnFj

Finally, I got 1 suggestion to enhance your package : the support of local images, it would be cool :D

cakebake commented 9 years ago

I'm going to run some tests with your Markdown. Thank you for providing :)

Regarding your proposal with the local images ... I think that's definitely important!! Currently I have a few more local branches in which I perform tests. The best result counts.

cakebake commented 9 years ago

Ok, block comments no longer stop the document in v0.2.0 :) comments.markdown.pdf

Local images coming soon.

Gaoura commented 9 years ago

Haha nice ! Thank you :)

cakebake commented 9 years ago

Supports local images by 949616acb760cadb586446c3061ece80608351d4 :)