search

cakebaker / scss-syntax.vim

Vim syntax file for scss (Sassy CSS)
386 stars 71 forks source link

scss-syntax.vim + css.vim seems to break `border-radius` highlighting #37

Closed jsit closed 10 years ago

jsit commented 10 years ago

With Vim 7.3 and only scss-syntax.vim and css.vim installed, border-radius is highlighted as separate strings:

screen shot 2014-02-22 at 5 31 29 pm

kristijanhusak commented 10 years ago

It's probably problem in your css.vim syntax file, because here looks good.

scss-border-radius

cakebaker commented 10 years ago

I can reproduce it in Vim 7.3, but not in Vim 7.4.

It seems that the problem is that for some reason border is recognized as a type defined in the css.vim bundled with Vim 7.3 if the snippet is in a scss file. If the snippet is in a css file, however, the correct type is recognized and it is highlighted correctly...

jsit commented 10 years ago

Same here -- just tested with MacVim 7.4. Everything works fine.

In Vim 7.3, if I set ft=css.scss (or css), you're right, it's highlighted correctly, but then other Sass-specific things aren't highlighted correctly.

If I have just css.vim installed, border-radius is highlighted correctly. If I have both css.vim and scss-syntax.vim installed -- or just scss-syntax.vim installed -- the highlighting is incorrect. (If I have neither installed, border-radius highlighting is incorrect, as is expected.)

Is this something that can be addressed by scss-syntax.vim, or should I look elsewhere for a solution?

cakebaker commented 10 years ago

Fixed in https://github.com/cakebaker/scss-syntax.vim/commit/62665ca385fbc05a421366beb928094e9b161b78. Thanks for reporting.