search

cakebaker / scss-syntax.vim

Vim syntax file for scss (Sassy CSS)
386 stars 71 forks source link

Set file type to scss, revert #17 #41

Closed runar closed 10 years ago

runar commented 10 years ago

My opinion is that the file type of SCSS files should be scss, not scss.css. Mostly because the two syntaxes available for Sass; SCSS and Sass, use the file extensions .scss and .sass, but also because several other plugins, such as vim-css-color, is affected by the Sass syntax and file type set by this plugin.

When the file type is set to scss.css, these other plugins will not detect that the SCSS file is indeed a SCSS file. This results in the plugins being unable to do their job, which is not good.

The merged pull request #17 allowed "css-related things to work straight away with scss files", but I think that there are better ways to make CSS-related things work out of the box than changing the file type to something that breaks compatibility with other plugins.

cakebaker commented 10 years ago

Hm, I'm unsure about this. I see your point but I don't know whether this is just a theoretical issue or a real one. Because the plugin you mention (vim-css-color) doesn't work with SCSS files here, whether the change is applied or not...

On the other hand I see the benefit for the snipmate plugin mentioned in #17 (and so far I didn't encounter any issues with the scss.css file type setting).

I think that there are better ways to make CSS-related things work out of the box

That's possible as I'm not a Vim expert. It's something I have to investigate.

runar commented 10 years ago

Thank you for your comment!

The issue was fist reported in ap/vim-css-color#35 and affects me as well. I guess that makes it real, not just a theoretical one. However, since several plugins are involved, I’ll do some investigating myself to confirm that the issue is caused by this plugin, not any of the other plugins.

I’m not using the snipmate plugin, but I’ll try it out and see if I can think of any other way to make it work «out of the box» with scss as the file type.

matphy commented 10 years ago

hi, I want to provide a remark that when the file type is set to scss.css, csslint and scsslint will be both actived by vim plugin syntastic.

MarioRicalde commented 10 years ago

It's also a problem for me. I've manually fixed for now...

Regards.

maple-leaf commented 10 years ago

Me too. It will make ultisnips to use css and scss snippets. And then if use extend css in scss snippet file, then a repeating snippet issue will come out.

cakebaker commented 10 years ago

Ok, you guys convinced me ;-) I reverted the change and added a hint to the readme. Thanks for your comments.