Some properties not highlighted

cakebaker / scss-syntax.vim

Vim syntax file for scss (Sassy CSS)

386 stars 71 forks source link

Closed alem0lars closed 9 years ago

alem0lars commented 9 years ago

Ok, without the rainbow plugin a lot of issues are gone.

Still there are some small issues, in particular some properties aren't highlighted.

As usual, I attach some screenshots..

screen shot 2015-03-02 at 08 28 51

Thanks for the support :smile:

cakebaker commented 9 years ago

Ok, I can reproduce the issues. However, the issues in the second screenshot are CSS issues, i.e. you will also see them in CSS files:

hyphens and overflow-wrap are not (yet) recognized by Vim's CSS syntax (you could use a plugin like https://github.com/hail2u/vim-css3-syntax to add CSS3 support)
listing, plaintext, and xmp are obsolete elements you should no longer use (see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/plaintext).

alem0lars commented 9 years ago

Ok,

I have tested with vim-css3-syntax and the new attributes (like animate-*) now works fine :smile:

So the problems now should be:

map-merge not highlighted: I think fixed in commit 8901b3b. I will test the fix as soon as it's released
classes inside pseudo-selectors, like :not(.animate-once)
boolean keywords: true and false

Do you think that unquoted strings should be highlighted too (atm they aren't)?

Thanks for the awesome support, Alessandro

alem0lars commented 9 years ago

FYI also logical operators like not, or, and, etc.. aren't highlighted

cakebaker commented 9 years ago

The issue with map-merge is fixed, however, there is a second issue in that snippet: the map used as parameter is not recognized.

Yes, I think unquoted strings should be highlighted.

alem0lars commented 9 years ago

Ok, I've tested the bugfixes and they work correctly :smile:
I think the only missing bugfix is the one for classes inside pseudo-selectors:

cakebaker commented 9 years ago

I think all issues are fixed now. Thanks for reporting!