5.x - Update Milligram to 1.4.1, adjust stylings and fix problem with DB connection test

[LordSimal]

This PR contains a few changes 😄

Update Milligram to 1.4.1

Here I just downloaded the latest minified version of the milligram Framework, replaced the file in webroot/css/milligram.min.css and checked if everything still works fine.

Here I noticed, that the current version of milligram doesn't have a column-responsive class anymore. Therefore I will create a separate PR for cakephp/bake which adjust the bake template to not use that class anymore.

Fix default homepage DB connection test

We changed the signature of Driver::connect() to be void instead of bool because we throw an exception when there is an error trying to connect. Therefore I adjusted the logic to show correctly if the currently set connections are functional or not.

Adjust styling for pagination

I took the liberty to adjust the styling of our default paginator:

In my opinion this looks a bit better than what we have currently.

Download Raleway Google Font and include statically

Since I had to do basically this exact thing on dozens of other pages for my company I did the same here. I basically downloaded all the raleway WOFF2 files, put it in the font folder and statically linked the font-faces to that file.

The main reason here is the fact, that according to GDPR it is not allowed to load Google Fonts via an external URL because the IP address is being sent to Google (of course, otherwise transportation of data won't work) but for some reason this is not allowed without user consent........ ANYWAY

With that out of the way the only external file we are currently loading is the CakePHP logo on the default homepage (which is fine I would say)

Put every color inside a CSS var and cleanup cake.css

Since we already introduces CSS variables in the DebugKit CSS/JS rework I have now also added them in here.

The only other thing I can show you is how all the major input types look by default:

If you think something can be adjusted please tell me 😄

[ADmad]

Using local fonts instead of from google is something that should be done for 4.x too. Besides the GDPR issue that would make working locally easier without internet access.

[LordSimal]

Using local fonts instead of from google is something that should be done for 4.x too

I can do that in a follow up PR 👍🏻

[ADmad]

Based on release notes of 1.4.0 normalize.css is already included in milligram. So could you try without it?

[markstory]

I basically downloaded all the raleway WOFF2 files, put it in the font folder and statically linked the font-faces to that file.

Is this within the licensing of google fonts? We don't want to be infringing on their licensing. If it isn't we can use standard web-safe fonts instead.

[ADmad]

Is this within the licensing of google fonts?

Raleway is licensed under the SIL Open Font License. So I don't think where source them from should matter.

[LordSimal]

The Pagination styling has now been reverted to this state:

[garas]

License has this condition:

2) Original or Modified Versions of the Font Software may be bundled, redistributed and/or sold with any software, provided that each copy contains the above copyright notice and this license. These can be included either as stand-alone text files, human-readable headers or in the appropriate machine-readable metadata fields within text or binary files as long as those fields can be easily viewed by the user.

So it should include license somewhere with font files.

[berarma]

Milligram 1.4.x doesn't include normalize.css, it's a dependency.

[LordSimal]

Then the release notes for 1.4.0 are pretty misleading... Can you provide a PR which re-adds the latest version of normalize.css again?

[berarma]

Then the release notes for 1.4.0 are pretty misleading... Can you provide a PR which re-adds the latest version of normalize.css again?

I understand it as updating dependencies. I tested it with and without normalize and the only change I noticed was the body margin. That's on my browser but since normalize is used to remove browser differences it could be different in others browsers.

If there's no objections about me being wrong I'll do a PR tomorrow.