Closed LordSimal closed 1 year ago
Isn't that what addOptionalPlugin is for?
Isn't that what addOptionalPlugin is for?
It is for dev dependencies (require-dev
in composer.json
).
Repl in not included neither in require
or require-dev
, only in suggest
.
Sure, but it's the same concept. We could just comment it out I guess.
Sure, but it's the same concept. We could just comment it out I guess.
By that logic we should then optionally load
markstory/asset_compress
anddereuromark/cakephp-ide-helper
as well
Sure. If we're suggesting it. This is just a helpful template to show where things go, right.
I am fine with either one of the solutions - either remove all or add all suggestions which are actual CakePHP plugin suggestions
@ADmad what do you think? I don't have a strong opinion, just thought it could be used for this.
I don't have a strong opinion on this either but would lean towards removing it. I don't remember anyone mentioning using the repl plugin in any of our help channels in a long time.
Also one major gripe I have with the repl plugin / psysh is that it pulls in a symfony package which override our dd()
function.
Sounds good, merging since this isn't a major issue.
either remove all or add all suggestions which are actual CakePHP plugin suggestions
Removing makes sense to me. We don't need to clutter people's applications with a bunch of commented out code when we also give them CLI tools to add the lines back in if required.
cakephp/repl isn't being installed by default anymore, therefore we shouldn't load it by default as well. Refs: https://github.com/cakephp/app/pull/878