cakephp / app

CakePHP application template
370 stars 391 forks source link

4.x: remove loading repl plugin in bootstrap cli #941

Closed LordSimal closed 1 year ago

LordSimal commented 1 year ago

cakephp/repl isn't being installed by default anymore, therefore we shouldn't load it by default as well. Refs: https://github.com/cakephp/app/pull/878

othercorey commented 1 year ago

Isn't that what addOptionalPlugin is for?

garas commented 1 year ago

Isn't that what addOptionalPlugin is for?

It is for dev dependencies (require-dev in composer.json).

Repl in not included neither in require or require-dev, only in suggest.

othercorey commented 1 year ago

Sure, but it's the same concept. We could just comment it out I guess.

LordSimal commented 1 year ago

Sure, but it's the same concept. We could just comment it out I guess.

By that logic we should then optionally load

as well

othercorey commented 1 year ago

Sure. If we're suggesting it. This is just a helpful template to show where things go, right.

LordSimal commented 1 year ago

I am fine with either one of the solutions - either remove all or add all suggestions which are actual CakePHP plugin suggestions

othercorey commented 1 year ago

@ADmad what do you think? I don't have a strong opinion, just thought it could be used for this.

ADmad commented 1 year ago

I don't have a strong opinion on this either but would lean towards removing it. I don't remember anyone mentioning using the repl plugin in any of our help channels in a long time.

ADmad commented 1 year ago

Also one major gripe I have with the repl plugin / psysh is that it pulls in a symfony package which override our dd() function.

othercorey commented 1 year ago

Sounds good, merging since this isn't a major issue.

markstory commented 1 year ago

either remove all or add all suggestions which are actual CakePHP plugin suggestions

Removing makes sense to me. We don't need to clutter people's applications with a bunch of commented out code when we also give them CLI tools to add the lines back in if required.