search

cakephp / app

CakePHP application template
370 stars 391 forks source link

Update AjaxView.php use setResponse #969

Closed markusramsak closed 1 year ago

ADmad commented 1 year ago

This is an unnecessary change (not to mention fails even the linter). There's no problem assigning the protected property directly.

markusramsak commented 1 year ago

This is an unnecessary change (not to mention fails even the linter). There's no problem assigning the protected property directly.

I made a typo "=" should of course be ";" I know that assigning a protected property is not an error but I thought that we could use setResponse and setRequest everywhere without exceptions to be consistent ...