search

cakephp / authentication

Authentication plugin for CakePHP. Can also be used in PSR7 based applications.
MIT License
117 stars 99 forks source link

bump to php-jwt 6.2 and remove temporary/deprecated code #507

Closed swiffer closed 2 years ago

ndm2 commented 2 years ago

I'm surprised that this didn't break any tests, given the breaking change in JWT::decode(). Seems like there never were any tests for anything other than the default algorithm(s) config.

ADmad commented 2 years ago

I'm surprised that this didn't break any tests, given the breaking change in JWT::decode(). Seems like there never were any tests for anything other than the default algorithm(s) config.

Me too. Good thing that we have static analysis :slightly_smiling_face:.

Also this will be a breaking change for users and even a minor version bump will not be enough IMO. The JWT authentication will simply break unless users upgrade the firebase/php-jwt packages in their apps.

cnizzardini commented 2 years ago

Docs should be updated as part of this, especially since this PR: https://github.com/cakephp/authentication/pull/531

swiffer commented 2 years ago

I've updated this PR.

I merged 2.x into 2.next as 2.next was several commits behind. Docs have been updated, deprecated code has been removed. I bumped php-jwt to ^6.2 as this will add support for cached JWKS keysets (to be used in an upcoming PR)

As suggested by @ADmad should this become v 3.0 instead ?

ADmad commented 2 years ago

@markstory ping