search

cakephp / authorization

PSR7 Middleware for authorization
MIT License
76 stars 46 forks source link

move unauthorizedHandler to AuthorizationService #192

Closed saeideng closed 1 year ago

saeideng commented 2 years ago

do we need move all configs from AuthorizationMiddleware to AuthorizationService or only the unauthorizedHandler ?

my opinion : moving all

markstory commented 2 years ago

my opinion : moving all

Would you also be moving all the logic related to these options to the service as well?

saeideng commented 2 years ago

my opinion : moving all

Would you also be moving all the logic related to these options to the service as well?

not sure , but I can try it

ADmad commented 2 years ago

I didn't see this PR earlier. #211 adds the unauthorizedHandler to both the middlewares using a trait instead.