Feature: BeforeScopeInterface (2.x)

cakephp / authorization

PSR7 Middleware for authorization

MIT License

76 stars 46 forks source link

Feature: BeforeScopeInterface (2.x) #261

Closed jamisonbryant closed 10 months ago

jamisonbryant commented 10 months ago

See https://github.com/cakephp/authorization/pull/260/ for a detailed description.

This PR contains the same changes for the 2.x branch (CakePHP v4) branch.

Checklist

[x] Tests written and passing
[x] Code follows coding standards
[x] Documentation updated if necessary
[x] Spelling/grammar check done

jamisonbryant commented 10 months ago

The two stan failures are for src/Identity.php which is not a file I touched. It looks like Psalm wants me to expand the return types, but I'm not sure if I should do that since it's unrelated to the changes made in this PR.

Any suggestions what I should do? All the other checks pass.

ADmad commented 10 months ago

Please rebase your changes on the 2.next branch.

New features need to target The x.next branches as they require new minor releases.

jamisonbryant commented 10 months ago

@ADmad I think I did it, but I'm not so familiar with doing rebases on a fork. Does it look right now?

jamisonbryant commented 10 months ago

Closing, will attempt to recreate and hope that cleans up the commits.