search

cakephp / cakephp-codesniffer

CakePHP Code Sniffer
http://cakephp.org
MIT License
238 stars 85 forks source link

Cake 5 CS #368

Open dereuromark opened 1 year ago

dereuromark commented 1 year ago

I see that current Cake5 sniffer version is still 7.2+ It seems to work with union types and other PHP 8+ topics, but still is PHP 7

Is there any plan to make the new major that is working with Cake5 and PHP 8 also tailored for it? Or will it also be suitable for previous Cake versions etc?

I am asking, because if we tailor it to PHP 8+, we can also further include specific 8+ enhancements, e.g.

    <rule ref="SlevomatCodingStandard.Functions.RequireTrailingCommaInDeclaration"/>
    <rule ref="SlevomatCodingStandard.Functions.RequireTrailingCommaInClosureUse"/>

which improve diffing

Amonst a few other sniffs.

ADmad commented 1 year ago

Probably an oversight, v5 of the code-sniffer should be PHP 8.1+.