search

cakephp / cakephp-codesniffer

CakePHP Code Sniffer
http://cakephp.org
MIT License
238 stars 85 forks source link

Update ruleset.xml #381

Closed swiffer closed 1 year ago

swiffer commented 1 year ago

v5 is not allowing slevomat/coding-standard v6 and it's giving deprecation errors in newer versions of php.

Deprecated: Creation of dynamic property SlevomatCodingStandard\Sniffs\TypeHints\DeclareStrictTypesSniff::$newlinesCountAfterDeclare is deprecated

ref: https://github.com/squizlabs/PHP_CodeSniffer/pull/3629#issuecomment-1500485945

the propertytypehint sniff has no enableStaticTypeHint option:

https://github.com/slevomat/coding-standard/blob/master/SlevomatCodingStandard/Sniffs/TypeHints/PropertyTypeHintSniff.php#L68

ADmad commented 1 year ago

v5 is not allowing slevomat/coding-standard v6

This 5.x branch uses slevomat/coding-standard v8 https://github.com/cakephp/cakephp-codesniffer/blob/5.x/composer.json#L23

I haven't encountered any errors using cakephp-codesniffer v5 on PHP 8.2. It's v4 that needs to be updated.

ADmad commented 1 year ago

Sorry I misunderstood, thank you for the report. I have removed the defunct props for 5.x in 4728b69.

swiffer commented 1 year ago

Yes but the ruleset makes use of Settings Not available in V8. These lead to deprecarion warnings (If enabled) in PHP8.2.

ADmad commented 1 year ago

Yes but the ruleset makes use of Settings Not available in V8

They have been removed now https://github.com/cakephp/cakephp-codesniffer/commit/4728b69d3ea3aba412d995e0ba911c6abb5ce359

swiffer commented 1 year ago

There is one more (See my second commit)