Change only Chronos to extend DateTimeImmutable once again

cakephp / chronos

A standalone DateTime library originally based off of Carbon

http://book.cakephp.org/chronos

MIT License

1.34k stars 61 forks source link

Change only Chronos to extend DateTimeImmutable once again #417

Closed othercorey closed 9 months ago

othercorey commented 10 months ago

The original reasons for this change are described here: https://github.com/cakephp/chronos/issues/410#issuecomment-1722185717

[x] Need to improve unit tests with more non-Chronos arguments now that the type declarations are relaxed.

othercorey commented 10 months ago

Removed unnecessary Chronos type declaration from formatter methods.

othercorey commented 9 months ago

Would we want to release this as 3.1.0?

Up to you. It would make it possible for people to transition without forcing it on them, but we do want this to be official. However, the only feedback we've seen was initially negative (or at least not positive) to not extending DateTimeImmutable.

CakePHP 5 deps need to be updated to only support this.