search

cakephp / chronos

A standalone DateTime library originally based off of Carbon
http://book.cakephp.org/chronos
MIT License
1.34k stars 61 forks source link

Rename toNative() toDateTimeImmutable() #424

Closed othercorey closed 9 months ago

othercorey commented 9 months ago

The term "native" made sense internally only. This is more explicit and easier to find.

dereuromark commented 9 months ago

Isnt that bc breaking? Native sounded fine to me. Also, immutable should not be in there, leaking info

othercorey commented 9 months ago

It technically is although it was just added. Can add toNative() as an alias to ensure no breaks.

othercorey commented 9 months ago

I should have linked where this comes from - https://github.com/cakephp/chronos/issues/410#issuecomment-1726975219