search

cakephp / chronos

A standalone DateTime library originally based off of Carbon
http://book.cakephp.org/chronos
MIT License
1.34k stars 61 forks source link

Default Chronos::create() time components to 0 #426

Closed othercorey closed 9 months ago

othercorey commented 9 months ago

closes https://github.com/cakephp/chronos/issues/419

This expands the scope of the RFC a little since other wrappers that call Chronos::create() were also defaulting to null.

othercorey commented 9 months ago

The diff() test changes are due to a limitation in DatePeriod() where the end date isn't included when it's on exactly 00:00:00.

There is a new option in PHP 8.2 to include the end date that we should probably expose in the diff wrappers.