search

cakephp / chronos

A standalone DateTime library originally based off of Carbon
http://book.cakephp.org/chronos
MIT License
1.36k stars 63 forks source link

Method toNative() has gone missing #432

Closed shadowhand closed 1 year ago

shadowhand commented 1 year ago

https://github.com/cakephp/chronos/pull/417#pullrequestreview-1652711214

According to Semantic Versioning, methods and attributes MAY NOT be removed except in major releases. The toNative() method was present in versions 3.0.0 and 3.0.1, but removed in 3.0.2. This breaks expectations and trust in versioning.

dereuromark commented 1 year ago

Yes that removal was invalid, but got corrected https://github.com/cakephp/chronos/pull/427 Are u sure it is gone in your downloaded code and the actual release?

dereuromark commented 1 year ago

Ah, chronos class itself it is still missing

shadowhand commented 1 year ago

According to PR #417 it was removed in Chronos, ChronosDate, and ChronosTime. According to PR #427 it was only restored to ChronosDate and ChronosTime.

And yes, I have confirmed that the released package 3.0.2 does NOT have Chronos::toNative() method.

dereuromark commented 1 year ago

Pr open, will be released asap!

shadowhand commented 1 year ago

Thanks for the quick resolution!