Invalid deprecation error for Date::startOfWeek()

cakephp / chronos

A standalone DateTime library originally based off of Carbon

http://book.cakephp.org/chronos

MIT License

1.34k stars 61 forks source link

Invalid deprecation error for Date::startOfWeek() #453

Open jurchiks opened 1 month ago

jurchiks commented 1 month ago

I just updated my installation of Chronos to the latest available version for the project (PHP 7.3, so best I get is 2.4.4), and I got this nonsensical error: (new Date($anyDateHere))->addWeeks(1)->startOfWeek() throws 2.5 startOfDay() will be removed in 3.x. But this method calls startOfDay() implicitly, under the hood, users can't NOT call it.

othercorey commented 23 hours ago

@markstory What do you think?