Broken with cakephp 3.6

cakephp / codeception

CakePHP module for Codeception

Other

46 stars 28 forks source link

Broken with cakephp 3.6 #47

Open icex opened 6 years ago

icex commented 6 years ago

I recently upgraded to cake 3.6 and all my tests are broken.

Routes are not loaded at runtime, amOnRoute cannot be used(nothing is found). [Cake\Routing\Exception\MissingRouteException] A route matching "array (...
Router::reload(); in reloadRoutes can result in 'duplicate routes' errors. see https://github.com/cakephp/app/issues/593
- Lots of deprecated errors. Event::$data is deprecated. Use Event::getData() instead. eventManager() is deprecated. Use getEventManager()/setEventManager() instead. etc..

lorenzo commented 6 years ago

Would you like to send a pull request with the fix for this issue?

icex commented 6 years ago

Hi, working on it :)

dereuromark commented 6 years ago

Also note that "Lots of deprecated errors" doesnt mean broken. It can and should then just be silenced. It is good to support more than just the latest minor if possible here anyway. Only force ^3.6 as dependency here if really necessary and one is forced to use a new method that is only available in this new minor.

lorenzo commented 6 years ago

@icex Thanks so much!

icex commented 6 years ago

I have got it working on my branch (only for the latest version of cake, it should be 4.x ready) https://github.com/icex/codeception

I'll submit a PR after more testing and add back support for older versions