search

cakephp / codeception

CakePHP module for Codeception
Other
46 stars 28 forks source link

Updated .travis config for php 5.6 and 7.4 and cakephp/app 3.8 #51

Closed othercorey closed 4 years ago

othercorey commented 4 years ago

I'm not sure how the original tests were passing when the app config was copied only for version 3.1.

This has a number of php notices in phpunit tests and deprecation warnings.

othercorey commented 4 years ago

Fixed the default cake config which fixed the php notices.

othercorey commented 4 years ago

Fixed cakephp deprecation warnings except for sendHeaders(). I don't know why it's called here.

        $response->sendHeaders();
        return new BrowserKitResponse(
            $response->getBody(),
            $response->getStatusCode(),
            $response->getHeaders()
        );
ADmad commented 4 years ago

Could you please update the travis matrix to have a job which runs composer install with --prefer-lowest similar to https://github.com/cakephp/cakephp/blob/master/.travis.yml#L94. That will help ensure the updated methods exist in 3.4.

othercorey commented 4 years ago

With the http deprecation fixes, this requires cakephp 3.6. I updated the configs for this.

The --prefer-lowest solution doesn't seem to work with the way this script works. I added a job that pinned the cakephp/app version which pins the cakephp version.

othercorey commented 4 years ago

@dereuromark When you have some time, can you review this for us?

dereuromark commented 4 years ago

@dereuromark When you have some time, can you review this for us?

what do you mean? in general, the changes look good.

othercorey commented 4 years ago

what do you mean? in general, the changes look good.

Yes please. I did this just to give cake some love, but I'm unfamiliar with the project still. Admad wanted someone to review and you're so very very helpful ;)

dereuromark commented 4 years ago

I am not a codecept guru though :) So I can only look on the high level, which looks fine.