search

cakephp / datasources

CakePHP Datasources
http://cakephp.org
237 stars 114 forks source link

Code Conventions Cleanup #99

Closed cdburgess closed 10 years ago

cdburgess commented 10 years ago

I cleaned up the conventions. I only made minor changes to the code. I removed all of the error / warning ignoring. I did not add anything.

This was only a code convention cleanup.

cdburgess commented 10 years ago

Also, as a side note, MysqlLog extends Mysql and is throwing an error saying "Function mysql() has been deprecated".

AD7six commented 10 years ago

I recognise you went to some effort to get rid of the phpcs errors - but in part because of the absence of test (which is the "fault" of the repo), I don't want to merge this PR as is; it could cause users of the repository to find that it doesn't work as before.

Closing for now.