search

cakephp / docs

CakePHP CookBook
http://book.cakephp.org
Other
679 stars 2.58k forks source link

[4.next] Add blank line before return statements in examples #7843

Closed ravage84 closed 7 months ago

ravage84 commented 7 months ago

This brings the examples in line with the CakePHP coding conventions / code style standard, respectively:

https://book.cakephp.org/4/en/contributing/cakephp-coding-conventions.html#method-definition

https://github.com/cakephp/cakephp-codesniffer/blob/b12f9307475a74f8ee7625c7741fe2f54598cb0b/docs/README.md#L14 https://github.com/cakephp/cakephp-codesniffer/blob/b12f9307475a74f8ee7625c7741fe2f54598cb0b/CakePHP/Sniffs/Formatting/BlankLineBeforeReturnSniff.php

dereuromark commented 7 months ago

Looks good.

othercorey commented 7 months ago

Why do this only in 4.next?

ravage84 commented 6 months ago

@othercorey I simply didn't come around doing it for 5.x, too.

Done now in #7852

othercorey commented 6 months ago

5.x is merged into 5.next. We don't need to make separate commits for docs.