search

cakephp / elastic-search

Elastic search datasource for CakePHP
Other
88 stars 53 forks source link

Update ruflin/elastica dependency to 5.0.0 #111

Closed lilHermit closed 4 years ago

lilHermit commented 7 years ago

The latest version of ES doesn't require a delete_by_query plugin the functionality is now in core and the query has changed from DELETE /type/query to POST /type/_delete_by_query

ruflin/elastica 5.0.0 has this change

lilHermit commented 7 years ago

Ok seems lots more has changed and updating to 5.0.0 breaks lots (for example Elastica\Filter\BoolFilter has gone)

markstory commented 7 years ago

The significant breaks in ruflin/elastica have made the last few upgrades hard :cry:

lilHermit commented 7 years ago

Yeah the top of BoolFilter in 3.2.3 is worrying ;-)

https://github.com/ruflin/Elastica/blob/3.2.3/lib/Elastica/Filter/BoolFilter.php

Seems like elastic-search needs substantial changes #movinggoalposts

josegonzalez commented 7 years ago

@lilHermit if you're interested in working on this, we'd love a pull request :)

lilHermit commented 7 years ago

@josegonzalez I was thinking of doing exactly that. I'll create a 5.0 branch locally and get started

josegonzalez commented 7 years ago

<3

github-actions[bot] commented 4 years ago

This issue is stale because it has been open for 120 days with no activity. Remove the stale label or comment or this will be closed in 15 days