search

cakephp / elastic-search

Elastic search datasource for CakePHP
Other
88 stars 53 forks source link

Fix use of deprecated methods #145

Closed CauanCabral closed 6 years ago

CauanCabral commented 6 years ago

Reviewing the latest changes, I found some flaws.

Plus the fixes, I updated how mapping type is derived from Index name, when not explicitly defined. I think that way should be more clear the differences between 'Index' and (mapping) 'Type' names.

lorenzo commented 6 years ago

You need to bump the minimum cakephp dev-requirement in composer.json

CauanCabral commented 6 years ago

@lorenzo ~3.5 or jump direct to ~3.6-beta?

lorenzo commented 6 years ago

are all the methods available in 3.5?

CauanCabral commented 6 years ago

Yeah, they are available since 3.4 I think - the deprecations fixed are internal only, but based on roadmap/direction of CakePHP core (splitting getter/setter methods).

CauanCabral commented 6 years ago

Should I bump the minimum cakephp dev-requirement anyway? There's no real requirement for that, I think.