Update method signature

cakephp / elastic-search

Elastic search datasource for CakePHP

Other

88 stars 53 forks source link

Update method signature #208

Closed ADmad closed 4 years ago

ADmad commented 4 years ago

Does anyone have any idea for fixing the failing tests? If not we can just merge and wait for someone with the time and knowledge regarding ES to look into it later.

othercorey commented 4 years ago

Merging this as it cleans up php parsing errors and allows CS to run. The branch names are causing confusion on other PRs.