search

cakephp / elastic-search

Elastic search datasource for CakePHP
Other
88 stars 53 forks source link

Allow use Elastica 7.x with CakePHP 3.6+ #226

Closed CauanCabral closed 4 years ago

CauanCabral commented 4 years ago

With that, someone using CakePHP 3.6+ can update your ElasticSearch instalation without more work

othercorey commented 4 years ago

Nothing is testing with Elastica 7. I don't see a stable release for 7.0 yet.

ruflin/elastica (6.1.1): Downloading (100%)

markstory commented 4 years ago

If we can have tests passing against elastica 7 then I'm a :+1: on this.

CauanCabral commented 4 years ago

I had tried explicity define cakephp\elastic-search: ^2.0.0 and rufflin\elastica: 7.0.0-dev in my local setup - but composer failed to met both requirements. So, changing locally composer.json as I suggested here, from cakephp\elastic-search I can run my code.

But, thinking better, I don't see that as correct. I will expect a final release from elastica and think better how to support two major versions of them.