search

cakephp / elastic-search

Elastic search datasource for CakePHP
Other
88 stars 53 forks source link

Php 8 compatibility error #249

Closed irongomme closed 3 years ago

irongomme commented 3 years ago

There is an error with PHP 8 : Fatal error: Declaration of Cake\ElasticSearch\Query::_execute() must be compatible with Cake\Datasource\QueryTrait::_execute(): Cake\Datasource\ResultSetInterface in /var/www/vendor/cakephp/elastic-search/src/Query.php on line 621

Which can fixed with in file /vendor/cakephp/elastic-search/src/Query.php (l621) : protected function _execute(): \Cake\Datasource\ResultSetInterface

markstory commented 3 years ago

No work has been done on this package to support PHP8. Would you like to help?

othercorey commented 3 years ago

I believe php 8 testing was disabled because it requires elasticsearch 7.

irongomme commented 3 years ago

Ok, so next step is to implement elastica 7.0, isn't it ?

markstory commented 3 years ago

Ok, so next step is to implement elastica 7.0, isn't it ?

Sounds like it.

JacobAGTyler commented 3 years ago

Is this fixed by #252

github-actions[bot] commented 3 years ago

This issue is stale because it has been open for 120 days with no activity. Remove the stale label or comment or this will be closed in 15 days

othercorey commented 3 years ago

elastic-search 3.3.0 should resolve this.