Upgrade to Elastica 7 and enable tests for PHP 8.0

cschomburg commented 3 years ago

Note: this is an early draft to get all the tests passing. I did not yet have a chance to test this in our application, or check for correctness of the changes. I'm submitting here for visibility and to get some early feedback.

Notable changes:

Mapping types are removed in Elastica 7, so I replaced them with the equivalent Index methods everywhere
I've enabled tests for PHP 8.0 and fixed the missing return type. I think the return type may be backported to 3.x to ease upgrading
Breaking: I removed Document::getType() since it is no longer applicable
Breaking: QueryBuilder::geoShapeIndex() has changed arguments
The tests for routing keys need an index with the correct number of routing shards in ES 7. I needed to extend the TestFixture for this.
ResultSetTest::testDecoratedMethods() is rather fragile with the new strict return types in Elastica 7. I've worked around this issue for now, but it should probably be refactored.

cschomburg commented 3 years ago

I've had a chance to test this with our application (mappings, queries, inserts & updates) and encountered no issues, so I'm marking this as ready.

othercorey commented 3 years ago

We need to create a new major version branch for this.

markstory commented 3 years ago

I've created a 3.x branch that contains what is in master currently. Later this week I can do a major release.

othercorey commented 3 years ago

It looks like a connection exception is thrown randomly https://github.com/cakephp/elastic-search/runs/2127910448#step:10:12

othercorey commented 3 years ago

@markstory Can we release this without the fixture changes?

markstory commented 3 years ago

Yes, I can tag a release from master when this was merged.

cakephp / elastic-search

Upgrade to Elastica 7 and enable tests for PHP 8.0 #252